router indexer functionality #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedavidmeister
requested changes
Dec 12, 2024
There was a problem hiding this comment.
high level review is that this would be a fairly large change from the upstream
i'm concerned that making such large changes is going down a road of divergence from what is supported, and at what point are we better off writing our own logic vs. rewriting large amounts of someone else's logic?
thedavidmeister
requested changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
resolves #28
Solution
This PR divides some big class methods of UniswapV3Base that have a lot of contract calls inside (getting pool reserves, getting pools liquidity, getting pools ticks), to smaller units that each do one specific contract call, in order to open up the path for each method to be called elsewhere individually if needed (in this case for calling them when some pools needs updating their data), as well as allows child classes (unique dexes) to override those methods as they need, since not all dexes have the exacts same Contract ABI and need the contract calls to be specific for them (this covers almost all of the deletion diffs in this PR).
Next some new methods added to handle pool data update with contract logs (work as indexer), this is a new feature that allows updating pool data for each dex, the old way of getting pool data is still in place, ie using direct contract calls to get/update pool data.
Checks
By submitting this for review, I'm confirming I've done the following: